-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: change the frontmatter of the Codebuddy Slash Commands #462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change the frontmatter of the Codebuddy Slash Commands #462
Conversation
📝 WalkthroughWalkthroughReplaces CodeBuddy slash-command frontmatter fields: removes Changes
Sequence Diagram(s)(omitted) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Review CompleteYour review story is ready! Comment !reviewfast on this PR to re-generate the story. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
@openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md:
- Line 8: The proposal says to remove the `name` frontmatter field but the
CodeBuddy configurator in codebuddy.ts still defines `name`; remove the `name`
property occurrences from the exported configurator/object in
src/core/configurators/slash/codebuddy.ts (the three places where `name` is set)
so the code matches the proposal, then run formatting/linting and update any
tests or documentation that referenced that field; alternatively, if keeping
`name` was intentional, update the proposal text to reflect that instead.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.mdopenspec/specs/cli-init/spec.mdopenspec/specs/cli-update/spec.mdsrc/core/configurators/slash/codebuddy.ts
🧰 Additional context used
📓 Path-based instructions (3)
openspec/changes/**/*.md
📄 CodeRabbit inference engine (openspec/AGENTS.md)
Scaffold proposal using
proposal.md,tasks.md, optionaldesign.md, and delta specs underopenspec/changes/<id>/
Files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.md
openspec/changes/**/specs/**/spec.md
📄 CodeRabbit inference engine (openspec/AGENTS.md)
openspec/changes/**/specs/**/spec.md: Use## ADDED|MODIFIED|REMOVED|RENAMED Requirementsheaders in spec delta files
Include at least one#### Scenario:per requirement in spec delta files
Use#### Scenario: Nameformat (4 hashtags) for scenario headers, not bullets or bold text
Use## ADDED Requirementsfor new orthogonal capabilities that can stand alone; use## MODIFIED Requirementsfor behavior changes of existing requirements
When using MODIFIED Requirements, paste the full requirement block including header and all scenarios
Files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.md
openspec/specs/**/spec.md
📄 CodeRabbit inference engine (openspec/AGENTS.md)
Use SHALL/MUST for normative requirements in spec files; avoid should/may unless intentionally non-normative
Files:
openspec/specs/cli-update/spec.mdopenspec/specs/cli-init/spec.md
🧠 Learnings (14)
📓 Common learnings
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/*/proposal.md : Ensure `proposal.md` includes sections: Why (1-2 sentences), What Changes (bullet list with breaking change markers), and Impact (affected specs and code)
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/specs/**/spec.md : Use `## ADDED|MODIFIED|REMOVED|RENAMED Requirements` headers in spec delta files
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.mdopenspec/specs/cli-init/spec.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/specs/**/spec.md : Use `## ADDED Requirements` for new orthogonal capabilities that can stand alone; use `## MODIFIED Requirements` for behavior changes of existing requirements
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/*.md : Scaffold proposal using `proposal.md`, `tasks.md`, optional `design.md`, and delta specs under `openspec/changes/<id>/`
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.mdsrc/core/configurators/slash/codebuddy.tsopenspec/specs/cli-init/spec.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/*/proposal.md : Ensure `proposal.md` includes sections: Why (1-2 sentences), What Changes (bullet list with breaking change markers), and Impact (affected specs and code)
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.mdsrc/core/configurators/slash/codebuddy.ts
📚 Learning: 2025-11-25T01:08:02.839Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:02.839Z
Learning: Use `@/openspec/AGENTS.md` to learn how to create and apply change proposals, spec format and conventions, and project structure and guidelines
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/specs/**/spec.md : Include at least one `#### Scenario:` per requirement in spec delta files
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Create `design.md` only when needed: cross-cutting changes, new external dependencies, significant data model changes, security/performance complexity, or pre-coding ambiguity
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.md
📚 Learning: 2025-11-25T01:08:02.839Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:02.839Z
Learning: Always open `@/openspec/AGENTS.md` when the request mentions planning or proposals (words like proposal, spec, change, plan), introduces new capabilities, breaking changes, architecture shifts, or performance/security work, or sounds ambiguous and needs the authoritative spec before coding
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/specs/**/spec.md : When using MODIFIED Requirements, paste the full requirement block including header and all scenarios
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/specs/**/spec.md : Use SHALL/MUST for normative requirements in spec files; avoid should/may unless intentionally non-normative
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.mdopenspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/specs/**/spec.md : Use `#### Scenario: Name` format (4 hashtags) for scenario headers, not bullets or bold text
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.mdopenspec/specs/cli-update/spec.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/*/tasks.md : Ensure `tasks.md` contains implementation checklist with numbered sections and checkbox items
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Check `openspec/project.md` for project conventions before creating specs
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.md
🔇 Additional comments (10)
src/core/configurators/slash/codebuddy.ts (4)
13-14: LGTM! Frontmatter updates align with CodeBuddy requirements.The addition of quoted
descriptionandargument-hintfield with the square bracket format improves consistency with CodeBuddy's documentation.
18-19: LGTM! Consistent frontmatter structure.The
applycommand now includes properargument-hintwith the correct[change-id]placeholder format.
23-24: LGTM! Archive command frontmatter is consistent.The
archivecommand follows the same pattern with quoted description and properargument-hintfield.
10-26: Thenamefield should be retained.Tests explicitly validate that CodeBuddy slash command files must contain the
namefield. The test attest/core/init.test.ts:1123assertsexpect(proposalContent).toContain('name: OpenSpec: Proposal');, confirming that the field is expected in the generated output. Similar assertions validate thenamefield for all three commands (proposal, apply, archive). Multiple other tools (Claude, Crush, Qoder) also include and test for thenamefield, indicating it is part of the expected slash command frontmatter format. The current implementation correctly retains it.openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md (1)
1-17: Proposal structure follows best practices.The proposal includes all required sections (Why, What Changes, Impact) as per coding guidelines. The rationale is clear and the impact is well-documented.
Based on learnings, the proposal correctly includes Why (1-2 sentences), What Changes (bullet list), and Impact (affected specs and code).
openspec/specs/cli-init/spec.md (1)
188-192: LGTM! Spec correctly documents CodeBuddy frontmatter requirements.The requirements correctly specify CodeBuddy-compatible YAML frontmatter with
descriptionandargument-hintfields, and the square bracket format for parameters. This aligns with the implementation insrc/core/configurators/slash/codebuddy.ts.As per coding guidelines, the spec uses SHALL for normative requirements appropriately.
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/tasks.md (1)
1-6: LGTM! Tasks file follows conventions.The tasks file includes numbered sections with checkbox items as expected. All implementation tasks are marked complete and align with the changes described in the proposal.
Based on learnings, the tasks.md correctly contains an implementation checklist with numbered sections and checkbox items.
openspec/specs/cli-update/spec.md (1)
66-71: LGTM! Update spec aligns with init spec requirements.The scenario correctly documents the update behavior for CodeBuddy slash commands, including the use of shared templates with YAML frontmatter, square bracket format for
argument-hint, and preservation of user customizations. This is consistent with the changes incli-init/spec.md.As per coding guidelines, the spec uses SHALL for normative requirements appropriately.
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-update/spec.md (1)
1-56: Spec structure and CodeBuddy frontmatter requirements are well-defined.The MODIFIED Requirements section properly documents the slash-command update behavior across all tools, with consistent scenario formatting and normative language. The CodeBuddy scenario (lines 17-21) and Factory Droid scenario (lines 40-45) correctly specify the YAML frontmatter structure with
descriptionandargument-hintfields, and the square bracket parameter format aligns with the PR objective of updating CodeBuddy frontmatter fields.openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/specs/cli-init/spec.md (1)
1-75: Spec comprehensively documents initialization requirements across 10 tools with proper CodeBuddy frontmatter specification.The MODIFIED Requirements properly define the
openspec initbehavior with well-formatted scenarios. The CodeBuddy scenario (lines 19-24) correctly specifies the new frontmatter structure withdescriptionandargument-hintfields using square bracket format, which aligns with the PR objective. The inclusion of two additional tools (Kilo Code and Codex) relative to the cli-update spec is appropriate, as initialization must support a broader set of tools than the update command refreshes. The Factory Droid scenario's inclusion of$ARGUMENTSplaceholder and Codex's use of$1placeholder correctly reflect tool-specific requirements.
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (3)
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md (3)
1-3: Condense the Why section to 1-2 sentences.The Why section exceeds the guideline of 1-2 sentences. The current paragraph combines problem identification, contextual comparison, and documentation review into a single long sentence. Consider splitting or condensing to focus on the core rationale.
Based on learnings: the
proposal.mdshould include Why section with 1-2 sentences.✏️ Proposed revision
## Why -CodeBuddy slash command configurator currently uses inconsistent frontmatter fields compared to other tools. It uses `category` and `tags` fields (like Crush) but should use `argument-hint` field (like Factory, Auggie, and Codex) for better consistency. Additionally, the `proposal` command is missing frontmatter fields entirely. After reviewing CodeBuddy's official documentation, the correct format should use `description` and `argument-hint` fields with square bracket parameter format. +CodeBuddy uses inconsistent frontmatter fields compared to other tools (Factory, Auggie, Codex). To align with CodeBuddy's official documentation and improve consistency, we need to replace `category`/`tags` with `argument-hint` and add missing frontmatter fields to the `proposal` command.
5-10: Mark breaking changes in the What Changes section.The bullet list should explicitly indicate which changes are breaking. Replacing
categoryandtagswithargument-hintis a breaking change for existing CodeBuddy configurations. Add a marker (e.g.,⚠️ BREAKING or similar notation) to affected items.Based on learnings: the
proposal.mdshould include What Changes as a bullet list with breaking change markers.✏️ Proposed revision
## What Changes -- Replace `category` and `tags` fields with `argument-hint` field in CodeBuddy frontmatter +- ⚠️ BREAKING: Replace `category` and `tags` fields with `argument-hint` field in CodeBuddy frontmatter - Add missing frontmatter fields to the `proposal` command - Use correct square bracket format for `argument-hint` parameters (e.g., `[change-id]`) - Ensure consistency with CodeBuddy's official documentation
12-16: Expand the Impact section with implications.While the section correctly identifies affected specs and code, consider adding detail on the implications: how these changes affect CodeBuddy users, what migration steps may be required, and any backward compatibility considerations.
✏️ Suggested expansion
## Impact - Affected specs: cli-init, cli-update - Affected code: `src/core/configurators/slash/codebuddy.ts` - CodeBuddy users will get proper argument hints in the correct format for slash commands +- Requires updates to existing CodeBuddy configurations using `category`/`tags` fields +- Existing templates must be migrated to use `argument-hint` format with square brackets
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
🧰 Additional context used
📓 Path-based instructions (1)
openspec/changes/**/*.md
📄 CodeRabbit inference engine (openspec/AGENTS.md)
Scaffold proposal using
proposal.md,tasks.md, optionaldesign.md, and delta specs underopenspec/changes/<id>/
Files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
🧠 Learnings (6)
📓 Common learnings
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/*/proposal.md : Ensure `proposal.md` includes sections: Why (1-2 sentences), What Changes (bullet list with breaking change markers), and Impact (affected specs and code)
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/*.md : Scaffold proposal using `proposal.md`, `tasks.md`, optional `design.md`, and delta specs under `openspec/changes/<id>/`
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/*/proposal.md : Ensure `proposal.md` includes sections: Why (1-2 sentences), What Changes (bullet list with breaking change markers), and Impact (affected specs and code)
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/*.md : Scaffold proposal using `proposal.md`, `tasks.md`, optional `design.md`, and delta specs under `openspec/changes/<id>/`
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
📚 Learning: 2025-11-25T01:08:02.839Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:02.839Z
Learning: Use `@/openspec/AGENTS.md` to learn how to create and apply change proposals, spec format and conventions, and project structure and guidelines
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/specs/**/spec.md : Use `## ADDED|MODIFIED|REMOVED|RENAMED Requirements` headers in spec delta files
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Create `design.md` only when needed: cross-cutting changes, new external dependencies, significant data model changes, security/performance complexity, or pre-coding ambiguity
Applied to files:
openspec/changes/archive/2026-01-09-fix-codebuddy-frontmatter-fields/proposal.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/core/init.test.ts (1)
1099-1140: Add test assertions forargument-hinton apply and archive commands.The test checks for
argument-hinton the proposal command (line 1125) but omits similar checks for apply and archive. Other tool tests (Factory, Codex, Auggie, CoStrict) verifyargument-hinton all three commands. Given the PR adds frontmatter for all three commands, ensure test coverage is complete.📝 Suggested test additions
Add after line 1133:
expect(applyContent).toContain('description: "Implement an approved OpenSpec change and keep tasks in sync."'); +expect(applyContent).toContain('argument-hint: "[change-id]"'); expect(applyContent).toContain('Work through tasks sequentially');Add after line 1138:
expect(archiveContent).toContain('description: "Archive a deployed OpenSpec change and update specs."'); +expect(archiveContent).toContain('argument-hint: "[change-id]"'); expect(archiveContent).toContain('openspec archive <id> --yes');
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
test/core/init.test.ts
🧰 Additional context used
🧠 Learnings (3)
📓 Common learnings
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/*.md : Scaffold proposal using `proposal.md`, `tasks.md`, optional `design.md`, and delta specs under `openspec/changes/<id>/`
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/*/proposal.md : Ensure `proposal.md` includes sections: Why (1-2 sentences), What Changes (bullet list with breaking change markers), and Impact (affected specs and code)
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/*/proposal.md : Ensure `proposal.md` includes sections: Why (1-2 sentences), What Changes (bullet list with breaking change markers), and Impact (affected specs and code)
Applied to files:
test/core/init.test.ts
📚 Learning: 2025-11-25T01:08:19.004Z
Learnt from: CR
Repo: Fission-AI/OpenSpec PR: 0
File: openspec/AGENTS.md:0-0
Timestamp: 2025-11-25T01:08:19.004Z
Learning: Applies to openspec/changes/**/*.md : Scaffold proposal using `proposal.md`, `tasks.md`, optional `design.md`, and delta specs under `openspec/changes/<id>/`
Applied to files:
test/core/init.test.ts
Summary by CodeRabbit
Bug Fixes
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.